Re: [PATCH v2 14/17] riscv: dts: microchip: add fpga fabric section to icicle kit
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-12-17 13:51:47
Also in:
linux-devicetree, linux-gpio, linux-i2c, linux-pwm, linux-riscv, linux-rtc, linux-spi, linux-usb, lkml
Hi Conor, On Fri, Dec 17, 2021 at 10:33 AM [off-list ref] wrote:
From: Conor Dooley <conor.dooley@microchip.com> Split the device tree for the Microchip MPFS into two sections by adding microchip-mpfs-fabric.dtsi, which contains peripherals contained in the FPGA fabric. Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Thanks for your patch!
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-fabric.dtsi@@ -0,0 +1,13 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* Copyright (c) 2020-2021 Microchip Technology Inc */ + +/ { + corePWM0: pwm@41000000 { + compatible = "microchip,corepwm"; + reg = <0x0 0x41000000 0x0 0xF0>; + microchip,sync-update = /bits/ 8 <0>; + #pwm-cells = <2>; + clocks = <&clkcfg CLK_FIC3>; + status = "disabled"; + };
I'm wondering if these should be grouped under a "fabric" subnode,
like we have an "soc" subnode for on-SoC devices? Rob?
BTW, do you already have a naming plan for different revisions of
FPGA fabric cores?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds