Re: [PATCHv5 00/12] nvme: In-band authentication support
From: Sagi Grimberg <sagi@grimberg.me>
Date: 2021-11-16 10:19:32
Also in:
linux-nvme
From: Sagi Grimberg <sagi@grimberg.me>
Date: 2021-11-16 10:19:32
Also in:
linux-nvme
quoted
quoted
quoted
quoted
- Transform secret with correct hmac algorithmIs that what I reported last time? Can you perhaps point me to the exact patch that fixes this?Well, no, not really; the patch itself got squashed in the main patches. But problem here was that the key transformation from section 8.13.5.7 had been using the hash algorithm from the initial challenge, not the one specified in the key itself. This lead to decoding errors when using a key with a different length than the hash algorithm.That is exactly what I reported, changing the key length leads to authentication errors.Right-o. So it should be sorted then.
Hannes, was the issue on the host side or the controller side? I'm a little lost into what was the actual fix...