Re: [PATCH] crypto: siphash - use _unaligned version by default

On Fri, Nov 26, 2021 at 4:26 PM Jason A. Donenfeld [off-list ref] wrote:

On Fri, Nov 26, 2021 at 10:18 AM Arnd Bergmann [off-list ref] wrote:

quoted

I have not tested this specific patch on all platforms, but I did
extensive testing of the get_unaligned()/put_unaligned() helpers
in my rewrite earlier this year[1], making sure that these are NOPs
on all the important architectures, and that they prevent the use
of trapping ldrd/ldm instructions on ARMv6/ARMv7.

If you're confident that the codegen doesn't change for ARMv8 and
x86{,_64}, then:

Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>

Thanks

We should probably Cc stable@, right?

Yes, I meant to add that but forgot.

I'm preparing a patchset for DaveM's stable tree today, and I can take
this in that patchset.

It's not urgent, but I think we need to fix it and get it into stable kernels
at some point. I'm happy with whatever timing works for you.

         Arnd