Re: [PATCH] crypto: ccree - remove redundant 'flush_workqueue()' calls
From: Cristian Marussi <cristian.marussi@arm.com>
Date: 2021-11-12 18:18:55
Also in:
kernel-janitors, lkml
On Fri, Nov 12, 2021 at 05:49:23PM +0100, Christophe JAILLET wrote:
'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle:
Hi Cristophe,
@@ expression E; @@ - flush_workqueue(E); destroy_workqueue(E); Signed-off-by: Christophe JAILLET <redacted>
LGTM. Reviewed-by: Cristian Marussi <cristian.marussi@arm.com> Thanks, Cristian
quoted hunk ↗ jump to hunk
--- drivers/crypto/ccree/cc_request_mgr.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/crypto/ccree/cc_request_mgr.c b/drivers/crypto/ccree/cc_request_mgr.c index 33fb27745d52..887162df50f9 100644 --- a/drivers/crypto/ccree/cc_request_mgr.c +++ b/drivers/crypto/ccree/cc_request_mgr.c@@ -101,7 +101,6 @@ void cc_req_mgr_fini(struct cc_drvdata *drvdata) dev_dbg(dev, "max_used_sw_slots=%d\n", req_mgr_h->max_used_sw_slots); #ifdef COMP_IN_WQ - flush_workqueue(req_mgr_h->workq); destroy_workqueue(req_mgr_h->workq); #else /* Kill tasklet */-- 2.30.2