Re: [PATCH v4 16/20] crypto: qce: core: Make clocks optional
From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Date: 2021-10-13 19:23:32
Also in:
linux-arm-msm, linux-devicetree, lkml
Hi Bhupesh, On 10/13/21 1:55 PM, Bhupesh Sharma wrote:
From: Thara Gopinath <redacted> On certain Snapdragon processors, the crypto engine clocks are enabled by default by security firmware and the driver need not/ should not handle the clocks. Make acquiring of all the clocks optional in crypto enginer driver
typo, s/enginer/engine/
so that the driver intializes properly even if no clocks are specified in
typo, s/intializes/initializes/
quoted hunk ↗ jump to hunk
the dt. Signed-off-by: Thara Gopinath <redacted> --- drivers/crypto/qce/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c index 2ab0b97d718c..576c416461f9 100644 --- a/drivers/crypto/qce/core.c +++ b/drivers/crypto/qce/core.c@@ -213,19 +213,19 @@ static int qce_crypto_probe(struct platform_device *pdev) if (IS_ERR(qce->mem_path)) return PTR_ERR(qce->mem_path); - qce->core = devm_clk_get(qce->dev, "core"); + qce->core = devm_clk_get_optional(qce->dev, "core"); if (IS_ERR(qce->core)) { ret = PTR_ERR(qce->core); goto err_mem_path_put; } - qce->iface = devm_clk_get(qce->dev, "iface"); + qce->iface = devm_clk_get_optional(qce->dev, "iface"); if (IS_ERR(qce->iface)) { ret = PTR_ERR(qce->iface); goto err_mem_path_put; } - qce->bus = devm_clk_get(qce->dev, "bus"); + qce->bus = devm_clk_get_optional(qce->dev, "bus"); if (IS_ERR(qce->bus)) { ret = PTR_ERR(qce->bus); goto err_mem_path_put;
-- Best wishes, Vladimir