[PATCH 06/12] nvme-fabrics: decode 'authentication required' connect error

[PATCHv3 00/12] nvme: In-band authentication support · Hannes Reinecke <hare@suse.de> · 2021-09-10
[PATCH 09/12] nvmet: Parse fabrics commands on all queues · Hannes Reinecke <hare@suse.de> · 2021-09-10
Re: [PATCH 09/12] nvmet: Parse fabrics commands on all queues · Sagi Grimberg <sagi@grimberg.me> · 2021-09-13
[PATCH 02/12] crypto: add crypto_has_kpp() · Hannes Reinecke <hare@suse.de> · 2021-09-10
Re: [PATCH 02/12] crypto: add crypto_has_kpp() · Sagi Grimberg <sagi@grimberg.me> · 2021-09-13
Re: [PATCH 02/12] crypto: add crypto_has_kpp() · Chaitanya Kulkarni <hidden> · 2021-09-16
[PATCH 06/12] nvme-fabrics: decode 'authentication required' connect error · Hannes Reinecke <hare@suse.de> · 2021-09-10
Re: [PATCH 06/12] nvme-fabrics: decode 'authentication required' connect error · Sagi Grimberg <sagi@grimberg.me> · 2021-09-13
Re: [PATCH 06/12] nvme-fabrics: decode 'authentication required' connect error · Chaitanya Kulkarni <hidden> · 2021-09-16
[PATCH 01/12] crypto: add crypto_has_shash() · Hannes Reinecke <hare@suse.de> · 2021-09-10
Re: [PATCH 01/12] crypto: add crypto_has_shash() · Sagi Grimberg <sagi@grimberg.me> · 2021-09-13
Re: [PATCH 01/12] crypto: add crypto_has_shash() · Chaitanya Kulkarni <hidden> · 2021-09-16
[PATCH 05/12] nvme: add definitions for NVMe In-Band authentication · Hannes Reinecke <hare@suse.de> · 2021-09-10
Re: [PATCH 05/12] nvme: add definitions for NVMe In-Band authentication · Sagi Grimberg <sagi@grimberg.me> · 2021-09-13
Re: [PATCH 05/12] nvme: add definitions for NVMe In-Band authentication · Chaitanya Kulkarni <hidden> · 2021-09-16
Re: [PATCH 05/12] nvme: add definitions for NVMe In-Band authentication · Hannes Reinecke <hare@suse.de> · 2021-09-17
[PATCH 08/12] nvme-auth: Diffie-Hellman key exchange support · Hannes Reinecke <hare@suse.de> · 2021-09-10
[PATCH 04/12] lib/base64: RFC4648-compliant base64 encoding · Hannes Reinecke <hare@suse.de> · 2021-09-10
[PATCH 12/12] nvmet-auth: expire authentication sessions · Hannes Reinecke <hare@suse.de> · 2021-09-10
[PATCH 11/12] nvmet-auth: Diffie-Hellman key exchange support · Hannes Reinecke <hare@suse.de> · 2021-09-10
[PATCH 03/12] crypto/ffdhe: Finite Field DH Ephemeral Parameters · Hannes Reinecke <hare@suse.de> · 2021-09-10
[PATCH 10/12] nvmet: Implement basic In-Band Authentication · Hannes Reinecke <hare@suse.de> · 2021-09-10
Re: [PATCH 10/12] nvmet: Implement basic In-Band Authentication · Sagi Grimberg <sagi@grimberg.me> · 2021-09-26
Re: [PATCH 10/12] nvmet: Implement basic In-Band Authentication · Sagi Grimberg <sagi@grimberg.me> · 2021-09-26
Re: [PATCH 10/12] nvmet: Implement basic In-Band Authentication · Hannes Reinecke <hare@suse.de> · 2021-09-27
Re: [PATCH 10/12] nvmet: Implement basic In-Band Authentication · Hannes Reinecke <hare@suse.de> · 2021-09-27
Re: [PATCH 10/12] nvmet: Implement basic In-Band Authentication · Sagi Grimberg <sagi@grimberg.me> · 2021-09-27
Re: [PATCH 10/12] nvmet: Implement basic In-Band Authentication · Hannes Reinecke <hare@suse.de> · 2021-09-27
Re: [PATCH 10/12] nvmet: Implement basic In-Band Authentication · Sagi Grimberg <sagi@grimberg.me> · 2021-09-28
Re: [PATCH 10/12] nvmet: Implement basic In-Band Authentication · Hannes Reinecke <hare@suse.de> · 2021-09-29
[PATCH 07/12] nvme: Implement In-Band authentication · Hannes Reinecke <hare@suse.de> · 2021-09-10
Re: [PATCH 07/12] nvme: Implement In-Band authentication · Sagi Grimberg <sagi@grimberg.me> · 2021-09-13
Re: [PATCH 07/12] nvme: Implement In-Band authentication · Hannes Reinecke <hare@suse.de> · 2021-09-13
Re: [PATCH 07/12] nvme: Implement In-Band authentication · Sagi Grimberg <sagi@grimberg.me> · 2021-09-14
Re: [PATCH 07/12] nvme: Implement In-Band authentication · Hannes Reinecke <hare@suse.de> · 2021-09-14
Re: [PATCH 07/12] nvme: Implement In-Band authentication · Sagi Grimberg <sagi@grimberg.me> · 2021-09-26
Re: [PATCH 07/12] nvme: Implement In-Band authentication · Hannes Reinecke <hare@suse.de> · 2021-09-27
Re: [PATCH 07/12] nvme: Implement In-Band authentication · Sagi Grimberg <sagi@grimberg.me> · 2021-09-27
Re: [PATCH 07/12] nvme: Implement In-Band authentication · Sagi Grimberg <sagi@grimberg.me> · 2021-09-26
Re: [PATCH 07/12] nvme: Implement In-Band authentication · Hannes Reinecke <hare@suse.de> · 2021-09-27
Re: [PATCH 07/12] nvme: Implement In-Band authentication · Sagi Grimberg <sagi@grimberg.me> · 2021-09-27
Re: [PATCHv3 00/12] nvme: In-band authentication support · Sagi Grimberg <sagi@grimberg.me> · 2021-09-13
Re: [PATCHv3 00/12] nvme: In-band authentication support · Hannes Reinecke <hare@suse.de> · 2021-09-13
Re: [PATCHv3 00/12] nvme: In-band authentication support · Sagi Grimberg <sagi@grimberg.me> · 2021-09-19

STALE1730d

From: Hannes Reinecke <hare@suse.de>
Date: 2021-09-10 06:44:41
Also in: linux-nvme
Subsystem: nvm express driver, the rest · Maintainers: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Linus Torvalds

The 'connect' command might fail with NVME_SC_AUTH_REQUIRED, so we
should be decoding this error, too.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/nvme/host/fabrics.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index 668c6bb7a567..9a8eade7cd23 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c

@@ -332,6 +332,10 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl,
 		dev_err(ctrl->device,
 			"Connect command failed: host path error\n");
 		break;
+	case NVME_SC_AUTH_REQUIRED:
+		dev_err(ctrl->device,
+			"Connect command failed: authentication required\n");
+		break;
 	default:
 		dev_err(ctrl->device,
 			"Connect command failed, error wo/DNR bit: %d\n",

-- 
2.29.2

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help