Re: [PATCH 2/5] crypto: hisilicon/sec - add ahash alg features for Kunpeng920

On Sat, Aug 28, 2021 at 11:16:47AM +0800, yekai(A) wrote:

I refered to other people's plans. Modify the value of halg.statesize
is sizeof(struct sec_req) + sizeof(u32), So user can allocate an extra
sizeof(u32) memory. The driver will write a tag number to the addr in the
export process, then the driver will check the pointers by the tag number
through the import path.
I think this plan can avoid random pointers.

I don't see what that's going to achieve.  The whole point of
export/import is to serialise the entire hash state.  You can
not store any pointers in there.  After all, I can export the
hash state, reboot, and then reimport the hash state and it
should still work.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt