On 30.07.21 02:31, Jarkko Sakkinen wrote:

On Thu, Jul 29, 2021 at 12:29:38AM +0200, Ahmad Fatoum wrote:

quoted

On 28.07.21 23:52, Jarkko Sakkinen wrote:

quoted

On Tue, Jul 27, 2021 at 06:24:49AM +0200, Ahmad Fatoum wrote:

quoted

On 27.07.21 05:04, Jarkko Sakkinen wrote:

quoted

quoted

Reported-by: Andreas Rammhold <redacted>
Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Is it absolutely need to do all this *just* to fix the bug?

For a pure bug fix the most essential thing is to be able the backport
it to stable kernels.

Not much happened in-between, so a backport should be trivial.
I can provide these if needed.

"not much" is not good enough. It should be "not anything".

"Not much" [code that could conflict was added in-between].

I just checked and it applies cleanly on v5.13. On the off chance
that this patch conflicts with another stable backport by the time
it's backported, I'll get a friendly automated email and send out
a rebased patch.

What you should do is to split this into patch that exactly
fixes the issue, and to one that adds the "niceties".

I'd rather not send out patches I believe to be incomplete, sorry.
If you want to fix the regression's root cause of insufficient
Kconfig description, that here is what it takes.

You can take Andreas' regression fix for stable and replace it with my patch later.
I'll send out a new version removing references that it fixes a regression.

Cheers,
Ahmad

/Jarkko

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |