Re: [RFC v2 1/4] hisi-acc-vfio-pci: add new vfio_pci driver for HiSilicon ACC devices

On Tue, Jul 06, 2021 at 05:39:25AM +0100, Christoph Hellwig wrote:

On Mon, Jul 05, 2021 at 03:32:47PM -0300, Jason Gunthorpe wrote:

quoted

It would be improved a bit by making the ops struct mutable and
populating it at runtime like we do in RDMA. Then the PCI ops and
driver ops could be merged together without the repetition.

No, that would be everything but an improvement.

Do you have an alternative? It has worked reasonably with the similar
RDMA problems.

Jason