Re: [PATCH v4 16/16] crypto/nx: Add sysfs interface to export NX capabilities

On Fri, 2021-06-04 at 21:52 +1000, Michael Ellerman wrote:

Haren Myneni [off-list ref] writes:

quoted

On Thu, 2021-06-03 at 14:57 +1000, Nicholas Piggin wrote:

quoted

Excerpts from Haren Myneni's message of May 21, 2021 7:42 pm:

quoted

Changes to export the following NXGZIP capabilities through
sysfs:

/sys/devices/vio/ibm,compression-v1/NxGzCaps:

Where's the horrible camel case name coming from? PowerVM?

Yes, pHyp provides the capabalities string.

Capability Description Descriptor Value Descriptor ascii Value
Overall NX Capabilities 0x4E78204361707320 “Nx Caps ”
NX GZIP Capabilities 0x4E78477A43617073 “NxGzCaps”

That doesn't mean we have to use that name in sysfs though. In fact
we
couldn't use the "Nx Caps " name, because it contains spaces.

And we don't have to squeeze our name into 8 bytes, so it can be less
ugly.

Like "nx_gzip_capabilities"?

Thanks for your comments. 

'NX Caps " provides the all available features in the hypervisor (only
NX GZIP caps is supported right now) and we export information for the
specific feature via sysfs.

I will change it to "nx_gzip_caps" 

Thanks
Haren

cheers