Thread (44 messages) 44 messages, 4 authors, 2021-05-11

Re: [PATCH V3 02/16] powerpc/vas: Move VAS API to common book3s platform

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2021-05-11 01:50:18
Also in: linuxppc-dev

Nicholas Piggin [off-list ref] writes:
Excerpts from Haren Myneni's message of April 18, 2021 7:02 am:
quoted
Using the same /dev/crypto/nx-gzip interface for both powerNV and
pseries.
The pseries NX driver will use the powernv VAS API ?
quoted
So this patch creates platforms/book3s/ and moves VAS API
to that directory. The actual functionality is not changed.

Common interface functions such as open, window open ioctl, mmap
and close are moved to arch/powerpc/platforms/book3s/vas-api.c
Added hooks to call platform specific code, but the underline
powerNV code in these functions is not changed.
Even so, could you do one patch that just moves, and another that
adds the ops struct?
quoted
Signed-off-by: Haren Myneni <haren@linux.ibm.com>
---
 arch/powerpc/include/asm/vas.h                | 22 ++++++-
 arch/powerpc/platforms/Kconfig                |  1 +
 arch/powerpc/platforms/Makefile               |  1 +
 arch/powerpc/platforms/book3s/Kconfig         | 15 +++++
 arch/powerpc/platforms/book3s/Makefile        |  2 +
The usual place for these would be arch/powerpc/sysdev/vas. E.g., see
arch/powerpc/sysdev/xive.
You're right that is the usual place, but is it a good place? :)

Using platforms/book3s was my suggestion:

  https://lore.kernel.org/linuxppc-dev/87k0p6s5lo.fsf@mpe.ellerman.id.au/ (local)


But I don't feel that strongly about it, maybe just dumping things in
sysdev is easier.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help