Re: [PATCH v2 00/13] Unify asm/unaligned.h around struct helper

From
Arnd Bergmann <arnd@kernel.org>
Date
2021-05-14 19:33:10
Also in
linux-arch, linux-arm-kernel, linux-block, linux-m68k, linux-security-module, linux-sh, linux-wireless, linuxppc-dev, lkml, netdev, sparclinux
Reply to
Linus Torvalds, 2021-05-14
On Fri, May 14, 2021 at 7:32 PM Linus Torvalds
[off-list ref] wrote:
On Fri, May 14, 2021 at 3:02 AM Arnd Bergmann [off-list ref] wrote:
quoted
I've included this version in the asm-generic tree for 5.14 already,
addressing the few issues that were pointed out in the RFC. If there
are any remaining problems, I hope those can be addressed as follow-up
patches.
This continues to look great to me, and now has the even simpler
remaining implementation.

I'd be tempted to just pull it in for 5.13, but I guess we don't
actually have any _outstanding_ bug in this area (the bug was in our
zlib code, required -O3 to trigger, has been fixed now, and the biggy
case didn't even use "get_unaligned()").

So I guess your 5.14 timing is the right thing to do.
Yes, I think that's best, just in case something does come up. While all the
object code I looked at does appear better, this is one of those areas that
can be hard to pinpoint if we hit a regression in a particular combination of
architecture+compiler+source file.

I have pushed a signed tag to
https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git
asm-generic-unaligned-5.14

and plan to send that in the 5.14 merge window unless you decide to
take it now after all.

        Arnd
Thread (23 messages) 23 messages, 8 authors, last reply 2021-12-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help