Re: [PATCH] crypto: hisilicon/hpre - delete redundant log

On 2021/4/2 15:19, Herbert Xu wrote:

On Sat, Mar 27, 2021 at 04:32:26PM +0800, Hui Tang wrote:

quoted

'hpre_cfg_by_dsm' has checked and printed error path, so it is not
necessary at all.

Signed-off-by: Hui Tang <redacted>
---
 drivers/crypto/hisilicon/hpre/hpre_main.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c b/drivers/crypto/hisilicon/hpre/hpre_main.c
index 8aae921..73ee997 100644
--- a/drivers/crypto/hisilicon/hpre/hpre_main.c
+++ b/drivers/crypto/hisilicon/hpre/hpre_main.c

@@ -384,10 +384,7 @@ static int hpre_set_user_domain_and_cache(struct hisi_qm *qm)

 	/* This setting is only needed by Kunpeng 920. */
 	if (qm->ver == QM_HW_V2) {
-		ret = hpre_cfg_by_dsm(qm);
-		if (ret)
-			dev_err(dev, "acpi_evaluate_dsm err.\n");
-
+		hpre_cfg_by_dsm(qm);
 		disable_flr_of_bme(qm);
 	}

If the return value is non-zero you've just changed what this code
does from returning non-zero to returning zero.  Are you sure about
this?

I am sorry, it should return error immediately when return value of 'hpre_cfg_by_dsm' is non-zero,
and I will fix it in the next version.