Thread (2 messages) 2 messages, 2 authors, 2021-04-02

Re: [PATCH] crypto: hisilicon/qm - delete redundant code

flat view

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2021-04-02 07:00:16
Also in: lkml

On Fri, Mar 26, 2021 at 09:14:32AM +0800, Kai Ye wrote:
The memory not needed to clear that will be freed. and the memset is useless
after the dma is freed.
I don't doubt that this memory probably doesn't need to be zeroed
since all it contains is a bunch of pointers instead of actual data.

But your patch description is poorly written and needs to be
rephrased to describe more clearly why it is safe to remove
the memset.

Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help