Re: [PATCH 07/10] crypto: caam: caampkc: Provide the name of the function and provide missing descriptions
From: Horia Geantă <horia.geanta@nxp.com>
Date: 2021-03-03 20:57:28
Also in:
lkml
On 3/3/2021 4:35 PM, Lee Jones wrote:
quoted hunk ↗ jump to hunk
Fixes the following W=1 kernel build warning(s): drivers/crypto/caam/caampkc.c:199: warning: expecting prototype for from a given scatterlist(). Prototype was for caam_rsa_count_leading_zeros() instead drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'xts_key_fallback' not described in 'caam_ctx' drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'fallback' not described in 'caam_ctx' Cc: "Horia Geantă" <horia.geanta@nxp.com> Cc: Aymen Sghaier <redacted> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones <redacted> --- drivers/crypto/caam/caamalg_qi2.c | 2 ++ drivers/crypto/caam/caampkc.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-)diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c index a780e627838ae..22e45c5bf2023 100644 --- a/drivers/crypto/caam/caamalg_qi2.c +++ b/drivers/crypto/caam/caamalg_qi2.c@@ -71,6 +71,8 @@ struct caam_skcipher_alg { * @adata: authentication algorithm details * @cdata: encryption algorithm details * @authsize: authentication tag (a.k.a. ICV / MAC) size + * @xts_key_fallback: whether to set the fallback key + * @fallback: the fallback key
I'd prefer having the doc updated as mentioned in v1: https://lore.kernel.org/linux-crypto/963b9e57-8077-5392-1d91-a5971e8d8ac5@nxp.com (local) Thanks, Horia