Re: [net-next v6 14/14] octeontx2-af: cn10k: MAC internal loopback support

Hi Geetha,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Geetha-sowjanya/Add-Marvell-CN10K-support/20210212-001410
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git e4b62cf7559f2ef9a022de235e5a09a8d7ded520
config: arm64-randconfig-r012-20210209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/afa77ec1a9bc63606c505997158f4d3940439f01
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Geetha-sowjanya/Add-Marvell-CN10K-support/20210212-001410
        git checkout afa77ec1a9bc63606c505997158f4d3940439f01
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

quoted

drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:731:38: warning: variable 'cgx_id' is uninitialized when used here [-Wuninitialized]

           mac_ops = get_mac_ops(rvu_cgx_pdata(cgx_id, rvu));
                                               ^~~~~~
   drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:726:11: note: initialize the variable 'cgx_id' to silence this warning
           u8 cgx_id, lmac_id;
                    ^
                     = '\0'

quoted

drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:734:8: warning: variable 'lmac_id' is uninitialized when used here [-Wuninitialized]

                                             lmac_id, en);
                                             ^~~~~~~
   drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:726:20: note: initialize the variable 'lmac_id' to silence this warning
           u8 cgx_id, lmac_id;
                             ^
                              = '\0'
   2 warnings generated.


vim +/cgx_id +731 drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c

   722	
   723	static int rvu_cgx_config_intlbk(struct rvu *rvu, u16 pcifunc, bool en)
   724	{
   725		struct mac_ops *mac_ops;
   726		u8 cgx_id, lmac_id;
   727	
   728		if (!is_cgx_config_permitted(rvu, pcifunc))
   729			return -EPERM;
   730	
 > 731		mac_ops = get_mac_ops(rvu_cgx_pdata(cgx_id, rvu));
   732	
   733		return mac_ops->mac_lmac_intl_lbk(rvu_cgx_pdata(cgx_id, rvu),
 > 734						  lmac_id, en);
   735	}
   736	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org