Re: [PATCH v2 3/3] crypto: hisilicon/sec - fixes shash test error
flat view
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2021-02-10 06:44:43
Also in:
lkml
On Sun, Feb 07, 2021 at 06:04:40PM +0800, Longfang Liu wrote:
quoted hunk ↗ jump to hunk
If the header file "crypto/internal/hash.h" not added, the allocation of crypto_tfm will fail when the shash algorithm calculates the hash through the software. Signed-off-by: Longfang Liu <liulongfang@huawei.com> --- drivers/crypto/hisilicon/sec2/sec_crypto.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c index d2c4a2c..988faf7 100644 --- a/drivers/crypto/hisilicon/sec2/sec_crypto.c +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c@@ -7,6 +7,7 @@ #include <crypto/des.h> #include <crypto/hash.h> #include <crypto/internal/aead.h> +#include <crypto/internal/hash.h>
Please explain what exactly in this file needs this header file. As it stands you could just be hiding real bugs. Thanks, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt