Re: [PATCH v5 06/11] crypto: qce: skcipher: Return error for non-blocksize data(ECB/CBC algorithms)
flat view
From: Eric Biggers <ebiggers@kernel.org>
Date: 2021-02-04 22:51:51
Also in:
lkml
On Thu, Feb 04, 2021 at 04:43:54PM -0500, Thara Gopinath wrote:
quoted hunk ↗ jump to hunk
+ /* + * ECB and CBC algorithms require message lengths to be + * multiples of block size. + * TODO: The spec says AES CBC mode for certain versions + * of crypto engine can handle partial blocks as well. + * Test and enable such messages. + */ + if (IS_ECB(rctx->flags) || IS_CBC(rctx->flags)) + if (!IS_ALIGNED(req->cryptlen, blocksize)) + return -EINVAL;
CBC by definition only operates on full blocks, so the TODO doesn't make sense. Is the partial block support really CTS-CBC? - Eric