Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

From
Vinod Koul <vkoul@kernel.org>
Date
2021-02-03 11:23:58
Also in
dri-devel, linux-clk, linux-devicetree, linux-gpio, linux-i2c, linux-iommu, linux-leds, linux-mmc, linux-watchdog, lkml
Reply to
Rob Herring, 2021-02-02
On 02-02-21, 14:55, Rob Herring wrote:
Properties in if/then schemas weren't getting checked by the meta-schemas.
Enabling meta-schema checks finds several errors.

The use of an 'items' schema (as opposed to the list form) is wrong in
some cases as it applies to all entries. 'contains' is the correct schema
to use in the case of multiple entries.

Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Chen-Yu Tsai <redacted>
Cc: Eric Anholt <redacted>
Cc: Nicolas Saenz Julienne <redacted>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Pavel Machek <redacted>
Cc: Ulf Hansson <redacted>
Cc: Kishon Vijay Abraham I <redacted>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <redacted>
Cc: Daniel Lezcano <redacted>
Cc: <redacted>
Cc: <redacted>
Cc: <redacted>
Cc: <redacted>
Cc: <redacted>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml   | 3 +--
 .../devicetree/bindings/display/brcm,bcm2835-hvs.yaml    | 2 +-
 Documentation/devicetree/bindings/leds/ti,tca6507.yaml   | 1 +
 Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml  | 2 +-
 Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml | 3 +--
 .../devicetree/bindings/phy/renesas,usb2-phy.yaml        | 5 ++---
For phy:

Acked-By: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod
Thread (16 messages) 16 messages, 11 authors, last reply 2021-02-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help