Thread (8 messages) 8 messages, 5 authors, 2021-01-22

Re: [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function

flat view

From: Ard Biesheuvel <ardb@kernel.org>
Date: 2021-01-15 17:26:18

On Fri, 15 Jan 2021 at 18:17, Jason A. Donenfeld [off-list ref] wrote:
With no mod_exit function, users are unable to load the module after
use. I'm not aware of any reason why module unloading should be
prohibited for this one, so this commit simply adds an empty exit
function.

Reported-by: John Donnelly <redacted>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
quoted hunk ↗ jump to hunk
---
 lib/crypto/chacha20poly1305.c | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c
index 5850f3b87359..c2fcdb98cc02 100644
--- a/lib/crypto/chacha20poly1305.c
+++ b/lib/crypto/chacha20poly1305.c
@@ -362,7 +362,12 @@ static int __init mod_init(void)
        return 0;
 }

+static void __exit mod_exit(void)
+{
+}
+
 module_init(mod_init);
+module_exit(mod_exit);
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("ChaCha20Poly1305 AEAD construction");
 MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
--
2.30.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help