Re: [PATCH 3/5] crypto: arm64/gcm - use variably sized key struct
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2020-07-09 12:12:34
On Thu, Jul 09, 2020 at 06:22:58PM +1000, Herbert Xu wrote:
On Mon, Jun 29, 2020 at 09:39:23AM +0200, Ard Biesheuvel wrote:quoted
Now that the ghash and gcm drivers are split, we no longer need to allocate a key struct for the former that carries powers of H that are only used by the latter. Also, take this opportunity to clean up the code a little bit. Signed-off-by: Ard Biesheuvel <ardb@kernel.org> --- arch/arm64/crypto/ghash-ce-glue.c | 49 +++++++++----------- 1 file changed, 21 insertions(+), 28 deletions(-)sparse doesn't like this patch either.
And some of these warnings appear to be genuine. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt