Thread (50 messages) 50 messages, 9 authors, 2020-07-22

Re: [PATCH 02/24] bpfilter: fix up a sparse annotation

From: Luc Van Oostenryck <hidden>
Date: 2020-07-21 02:40:24
Also in: bpf, bridge, linux-bluetooth, linux-can, linux-hams, linux-s390, linux-sctp, lkml, lvs-devel, mptcp, netdev, netfilter-devel

On Mon, Jul 20, 2020 at 02:47:15PM +0200, Christoph Hellwig wrote:
quoted hunk ↗ jump to hunk
The __user doesn't make sense when casting to an integer type.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 net/bpfilter/bpfilter_kern.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bpfilter/bpfilter_kern.c b/net/bpfilter/bpfilter_kern.c
index 977e9dad72ca4f..713b4b3d02005d 100644
--- a/net/bpfilter/bpfilter_kern.c
+++ b/net/bpfilter/bpfilter_kern.c
@@ -49,7 +49,7 @@ static int __bpfilter_process_sockopt(struct sock *sk, int optname,
 	req.is_set = is_set;
 	req.pid = current->pid;
 	req.cmd = optname;
-	req.addr = (long __force __user)optval;
+	req.addr = (__force long)optval;
For casts to integers, even '__force' is not needed (since integers
can't be dereferenced, the concept of address-space is meaningless
for them, so it's never useful to warn when it's dropped and
'__force' is thus not needed).

-- Luc
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help