Thread (26 messages) 26 messages, 5 authors, 2019-01-11

Re: [PATCH 04/16] crypto: pcbc - remove bogus memcpy()s with src == dest

From: David Howells <dhowells@redhat.com>
Date: 2019-01-04 17:24:26
Also in: stable

Eric Biggers [off-list ref] wrote:
It makes it clearer what's going on, especially since some modes update the
'iv' pointer after each block (delaying the copy to 'walk.iv' until the end)
but others can't do that.  The 'const' is helpful to further distinguish
these two cases, which were confused in both the pcbc and cfb
implementations.
I'm not sure I agree that it makes it clearer, but:

Reviewed-and-tested-by: David Howells [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help