Re: [PATCH] crypto: cavium/nitrox - Fix format strings
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2018-10-08 05:48:08
Also in:
lkml
On Tue, Oct 02, 2018 at 11:00:03PM +0200, Arnd Bergmann wrote:
The return type of atomic64_read() is unfortunately architecture
specific, it can be 'long', 'long long', or 's64'. When it is 'long',
we get a build warning:
drivers/crypto/cavium/nitrox/nitrox_debugfs.c: In function 'stats_show':
drivers/crypto/cavium/nitrox/nitrox_debugfs.c:62:30: error: format '%lld' expects argument of type 'long long int', but argument 3 has type 'long int' [-Werror=format=]
seq_printf(s, " Posted: %lld\n", atomic64_read(&ndev->stats.posted));
~~~^
%ld
drivers/crypto/cavium/nitrox/nitrox_debugfs.c:63:33: error: format '%lld' expects argument of type 'long long int', but argument 3 has type 'long int' [-Werror=format=]
seq_printf(s, " Completed: %lld\n",
~~~^
%ld
drivers/crypto/cavium/nitrox/nitrox_debugfs.c:65:31: error: format '%lld' expects argument of type 'long long int', but argument 3 has type 'long int' [-Werror=format=]
Add an explicit cast to 's64' to get a consistent behavior on all
architectures here during compile testing.
Fixes: 2a8780be9c26 ("crypto: cavium/nitrox - updated debugfs information.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>This patch doesn't apply to cryptodev because the bug has already been fixed by another patch. Thanks, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt