Thread (3 messages) 3 messages, 2 authors, 2018-09-18

Re: [PATCH][RFC] crypto: skcipher: Remove VLA usage

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2018-09-18 09:22:48
Also in: linux-arm-kernel, lkml

On Mon, Sep 17, 2018 at 10:30:36PM -0700, Kees Cook wrote:
On Thu, Sep 13, 2018 at 11:23 AM, Kees Cook [off-list ref] wrote:
quoted
RFC follow-up to https://lkml.kernel.org/r/CAGXu5j+bpLK=EQ9LHkO8V=sdaQwt==6fbGhgn2Vi1E9_WxSGRQ@mail.gmail.com

The core API changes:

        struct crypto_sync_skcipher
        crypto_alloc_sync_skcipher()
        crypto_free_sync_skcipher()
        crypto_sync_skcipher_setkey()
        skcipher_request_set_sync_tfm()
        SKCIPHER_REQUEST_ON_STACK type check

and a single user's refactoring as an example:

        drivers/crypto/ccp/ccp-crypto.h
        drivers/crypto/ccp/ccp-crypto-aes-xts.c

Does this look correct? If so, I can continue and do the other 60
instances of SKCIPHER_REQUEST_ON_STACK().
Herbert, how does this look? Should I do the other 60 instances? I'd
really like to get this finished up. :)
Hi Kees:

Yes I like this.  This looks a lot simpler than I thought it would
be.

Thanks!
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help