Re: [PATCH v2 1/2] dt-bindings: rng: Add new compatible qcom,prng-v2
From: Rob Herring <robh@kernel.org>
Date: 2018-06-25 19:06:16
Also in:
linux-arm-msm, linux-devicetree, lkml
On Tue, Jun 19, 2018 at 03:24:29PM +0530, Vinod Koul wrote:
quoted hunk ↗ jump to hunk
Later qcom chips support v2 of the prng, so add new compatible qcom,prng-v2 for this. Signed-off-by: Vinod Koul <vkoul@kernel.org> --- Cc: Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org Documentation/devicetree/bindings/rng/qcom,prng.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/rng/qcom,prng.txt b/Documentation/devicetree/bindings/rng/qcom,prng.txt index 8e5853c2879b..03fd218bd21a 100644 --- a/Documentation/devicetree/bindings/rng/qcom,prng.txt +++ b/Documentation/devicetree/bindings/rng/qcom,prng.txt@@ -2,7 +2,8 @@ Qualcomm MSM pseudo random number generator. Required properties: -- compatible : should be "qcom,prng" +- compatible : should be "qcom,prng" for 8916 etc + : should be "qcom,prng-v2" for 8996 and later
Either use SoC specific compatibles or convince me 'v2' is a meaningful and specific enough version. Some other QC IP has x.y.z versioning for example.
- reg : specifies base physical address and size of the registers map - clocks : phandle to clock-controller plus clock-specifier pair - clock-names : "core" clocks all registers, FIFO and circuits in PRNG IP block -- 2.14.4