Re: [PATCH v3 23/27] x86/modules: Adapt module loading for PIE support

On 05/23/2018 03:01 PM, Thomas Garnier wrote:

On Wed, May 23, 2018 at 2:27 PM Randy Dunlap [off-list ref] wrote:

quoted

Hi,

quoted

(for several patches in this series:)
The commit message is confusing.  See below.

Thanks for the edits, I will change the different commit messages.

quoted

On 05/23/2018 12:54 PM, Thomas Garnier wrote:

quoted

Adapt module loading to support PIE relocations. Generate dynamic GOT if
a symbol requires it but no entry exist in the kernel GOT.

quoted

                                     exists

quoted

quoted

Position Independent Executable (PIE) support will allow to extended the

quoted

                                                 will allow us to extend

the

quoted

quoted

KASLR randomization range below the -2G memory limit.

quoted

Does that say "below th negative 2G memory limit"?
I don't get it.

Yes, below 0xffffffff80000000 basically. I think I will just say that.

Yes, please, that's much better.

quoted

quoted

Signed-off-by: Thomas Garnier <redacted>
---
 arch/x86/Makefile               |   4 +
 arch/x86/include/asm/module.h   |  11 ++
 arch/x86/include/asm/sections.h |   4 +
 arch/x86/kernel/module.c        | 181 +++++++++++++++++++++++++++++++-
 arch/x86/kernel/module.lds      |   3 +
 5 files changed, 198 insertions(+), 5 deletions(-)
 create mode 100644 arch/x86/kernel/module.lds

quoted

Thanks,
--
~Randy

-- 
~Randy