Thread (14 messages) 14 messages, 4 authors, 2018-03-06

Re: [PATCH v11 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

From: Logan Gunthorpe <logang@deltatee.com>
Date: 2018-03-06 16:56:22
Also in: linux-arch, lkml


On 06/03/18 05:37 AM, Horia Geantă wrote:
On 3/5/2018 9:08 PM, Logan Gunthorpe wrote:
quoted
Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64
functions in non-64bit cases in favour of the new common
io-64-nonatomic-lo-hi header.

To be consistent with CAAM engine HW spec: in case of 64-bit registers,
irrespective of device endianness, the lower address should be read from
/ written to first, followed by the upper address. Indeed the I/O
accessors in CAAM driver currently don't follow the spec, however this
is a good opportunity to fix the code.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Cc: Andy Shevchenko <redacted>
Cc: Horia Geantă <horia.geanta@nxp.com>
Cc: Dan Douglass <redacted>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>

Please get used to carrying Reviewed-bys from previous iterations when patches
stay the same:
Sorry, I usually do this but I must have missed the email. Thanks.

Logan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help