Thread (10 messages) 10 messages, 6 authors, 2018-03-15

Re: [PATCH] crypto: ctr: avoid VLA use

From: Salvatore Mesoraca <hidden>
Date: 2018-03-14 13:46:29
Also in: lkml

2018-03-14 14:31 GMT+01:00 Stephan Mueller [off-list ref]:
Am Mittwoch, 14. März 2018, 14:17:30 CET schrieb Salvatore Mesoraca:

Hi Salvatore,
quoted
      if (walk.nbytes) {
-             crypto_ctr_crypt_final(&walk, child);
-             err = blkcipher_walk_done(desc, &walk, 0);
+             err = crypto_ctr_crypt_final(&walk, child);
+             err = blkcipher_walk_done(desc, &walk, err);
I guess you either want to handle the error from crypto_ctr_crypt_final or do
an err |= blkcipher_walk_done.
I think that blkcipher_walk_done handles and returns the error for me.
Am I wrong?

Best regards,

Salvatore
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help