Thread (13 messages) 13 messages, 2 authors, 2018-03-22
STALE3027d REVIEWED: 2 (0M)
Revisions (18)
  1. v9 [diff vs current]
  2. v9 [diff vs current]
  3. v10 [diff vs current]
  4. v11 [diff vs current]
  5. v12 [diff vs current]
  6. v13 [diff vs current]
  7. v14 current
  8. v15 [diff vs current]
  9. v16 [diff vs current]
  10. v17 [diff vs current]
  11. v18 [diff vs current]
  12. v19 [diff vs current]
  13. v20 [diff vs current]
  14. v21 [diff vs current]
  15. v22 [diff vs current]
  16. v23 [diff vs current]
  17. v24 [diff vs current]
  18. v25 [diff vs current]

[PATCH v14 01/10] iomap: Use correct endian conversion function in mmio_writeXXbe

From: Logan Gunthorpe <logang@deltatee.com>
Date: 2018-03-22 17:16:54
Also in: linux-arch, lkml
Subsystem: library code, the rest · Maintainers: Andrew Morton, Linus Torvalds

The semantics of the iowriteXXbe() functions are to write a
value in CPU endianess to an IO register that is known by the
caller to be in Big Endian. The mmio_writeXXbe() macro, which
is called by iowriteXXbe(), should therefore use cpu_to_beXX()
instead of beXX_to_cpu().

Seeing both beXX_to_cpu() and cpu_to_beXX() are both functionally
implemented as either null operations or swabXX operations there
was no noticable bug here. But it is confusing for both developers
and code analysis tools alike.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Luc Van Oostenryck <redacted>
Reviewed-by: Andy Shevchenko <redacted>
Cc: Philippe Ombredanne <redacted>
Cc: Thomas Gleixner <redacted>
Cc: Kate Stewart <redacted>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 lib/iomap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/iomap.c b/lib/iomap.c
index 541d926da95e..be120c13d6cc 100644
--- a/lib/iomap.c
+++ b/lib/iomap.c
@@ -106,8 +106,8 @@ EXPORT_SYMBOL(ioread32be);
 #endif
 
 #ifndef mmio_write16be
-#define mmio_write16be(val,port) __raw_writew(be16_to_cpu(val),port)
-#define mmio_write32be(val,port) __raw_writel(be32_to_cpu(val),port)
+#define mmio_write16be(val,port) __raw_writew(cpu_to_be16(val),port)
+#define mmio_write32be(val,port) __raw_writel(cpu_to_be32(val),port)
 #endif
 
 void iowrite8(u8 val, void __iomem *addr)
-- 
2.11.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help