Re: [PATCH -next] crypto: stm32 - remove redundant dev_err call in stm32_cryp_probe()
From: Fabien DESSENNE <hidden>
Date: 2018-01-17 13:02:40
Also in:
kernel-janitors, linux-arm-kernel
Hi, Thank you for the patch. On 17/01/18 12:40, Wei Yongjun wrote:
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun <redacted>
Reviewed-by: Fabien Dessenne <redacted>
quoted hunk ↗ jump to hunk
--- drivers/crypto/stm32/stm32-cryp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c index cf1dddb..4a06a7a 100644 --- a/drivers/crypto/stm32/stm32-cryp.c +++ b/drivers/crypto/stm32/stm32-cryp.c@@ -1052,10 +1052,8 @@ static int stm32_cryp_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); cryp->regs = devm_ioremap_resource(dev, res); - if (IS_ERR(cryp->regs)) { - dev_err(dev, "Cannot map CRYP IO\n"); + if (IS_ERR(cryp->regs)) return PTR_ERR(cryp->regs); - } irq = platform_get_irq(pdev, 0); if (irq < 0) {