Thread (2 messages) 2 messages, 2 authors, 2018-01-26
STALE3099d

[PATCH v2] crypto: inside-secure - make function safexcel_try_push_requests static

From: Antoine Tenart <hidden>
Date: 2018-01-16 07:45:03
Subsystem: crypto api, inside secure crypto driver, the rest · Maintainers: Herbert Xu, "David S. Miller", Antoine Tenart, Linus Torvalds

From: Colin Ian King <redacted>

The function safexcel_try_push_requests  is local to the source and does
not need to be in global scope, so make it static.

Cleans up sparse warning:
symbol 'safexcel_try_push_requests' was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
[Antoine: fixed alignment]
Signed-off-by: Antoine Tenart <redacted>
---

Hi Colin, Herbert,

I took care of making the v2 of this patch since the fix was trivial and
v1 was sent 2 weeks ago.

Thanks!
Antoine

Since v1:
  - Fixed the alignment to match open parenthesis.

 drivers/crypto/inside-secure/safexcel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
index 0d685be75241..225e74a7f724 100644
--- a/drivers/crypto/inside-secure/safexcel.c
+++ b/drivers/crypto/inside-secure/safexcel.c
@@ -432,8 +432,8 @@ static int safexcel_hw_init(struct safexcel_crypto_priv *priv)
 }
 
 /* Called with ring's lock taken */
-int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, int ring,
-			       int reqs)
+static int safexcel_try_push_requests(struct safexcel_crypto_priv *priv,
+				      int ring, int reqs)
 {
 	int coal = min_t(int, reqs, EIP197_MAX_BATCH_SZ);
 
-- 
2.14.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help