Re: [PATCH -next] hwrng: exynos - remove redundant dev_err call in exynos_trng_probe()
From: Łukasz Stelmach <l.stelmach@samsung.com>
Date: 2018-01-11 11:13:52
Also in:
kernel-janitors, linux-samsung-soc
It was <2018-01-10 śro 14:30>, when Wei Yongjun wrote:
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun <redacted>
Acked-by: Łukasz Stelmach <l.stelmach@samsung.com>
quoted hunk ↗ jump to hunk
--- drivers/char/hw_random/exynos-trng.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c index 34d6f51..4c8a2be 100644 --- a/drivers/char/hw_random/exynos-trng.c +++ b/drivers/char/hw_random/exynos-trng.c@@ -129,10 +129,8 @@ static int exynos_trng_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); trng->mem = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(trng->mem)) { - dev_err(&pdev->dev, "Could not map IO resources.\n"); + if (IS_ERR(trng->mem)) return PTR_ERR(trng->mem); - } pm_runtime_enable(&pdev->dev); ret = pm_runtime_get_sync(&pdev->dev);
-- Łukasz Stelmach Samsung R&D Institute Poland Samsung Electronics
Attachments
- signature.asc [application/pgp-signature] 472 bytes