Thread (4 messages) 4 messages, 2 authors, 2018-01-18

Re: [PATCH] crypto: ux500/hash: Add empty export and import

From: Kamil Konieczny <hidden>
Date: 2018-01-18 12:52:57
Also in: lkml


On 18.01.2018 11:06, Linus Walleij wrote:
On Tue, Jan 16, 2018 at 5:32 PM, Kamil Konieczny
[off-list ref] wrote:
quoted
Crypto framework will require async hash export/import, so add empty
functions to prevent OOPS.

Signed-off-by: Kamil Konieczny <redacted>
Acked-by: Linus Walleij <redacted>

But why isn't the framework code just checking the vtable for NULL?

if (foo->fp)
    foo->fp(bar);
This will be inefficient, 
it should be checked once at ahash alg register,
or with the old method by using wrapper

-- 
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help