Thread (2 messages) 2 messages, 2 authors, 2018-01-08

Re: [PATCH] staging: ccree: ssi_hash: remove unnecessary parentheses

flat view

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2018-01-08 15:07:52
Also in: lkml

On Thu, Dec 28, 2017 at 12:24:17PM +0200, Elad Wexler wrote:
Fixed a coding style issue

Signed-off-by: Elad Wexler <redacted>
---
 drivers/staging/ccree/ssi_hash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Why did you send this twice?
quoted hunk ↗ jump to hunk
diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging/ccree/ssi_hash.c
index 2035835..8d56fa7 100644
--- a/drivers/staging/ccree/ssi_hash.c
+++ b/drivers/staging/ccree/ssi_hash.c
@@ -2280,8 +2280,8 @@ int ssi_hash_alloc(struct ssi_drvdata *drvdata)
 				      &hash_handle->hash_list);
 		}
 
-		if ((hw_mode == DRV_CIPHER_XCBC_MAC) ||
-		    (hw_mode == DRV_CIPHER_CMAC))
+		if (hw_mode == DRV_CIPHER_XCBC_MAC ||
+		    hw_mode == DRV_CIPHER_CMAC)
No, now I have to go look up if == or || comes in which order.  Ick,
just leave it as-is please.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help