Thread (11 messages) 11 messages, 8 authors, 2017-12-28

Re: [PATCH] crypto: x86/twofish-3way - Fix %rbp usage

From: Ingo Molnar <mingo@kernel.org>
Date: 2017-12-19 07:54:51
Also in: lkml

* Eric Biggers [off-list ref] wrote:
There may be a small overhead caused by replacing 'xchg REG, REG' with
the needed sequence 'mov MEM, REG; mov REG, MEM; mov REG, REG' once per
round.  But, counterintuitively, when I tested "ctr-twofish-3way" on a
Haswell processor, the new version was actually about 2% faster.
(Perhaps 'xchg' is not as well optimized as plain moves.)
XCHG has implicit LOCK semantics on all x86 CPUs, so that's not a surprising 
result I think.

Thanks,

	Ingo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help