Re: [PATCH v3 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

It was <2017-12-04 pon 14:13>, when Krzysztof Kozlowski wrote:

On Mon, Dec 4, 2017 at 1:53 PM, Łukasz Stelmach [off-list ref] wrote:

quoted

Add binding documentation for the True Random Number Generator
found on Samsung Exynos 5250+ SoCs.

Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
 .../devicetree/bindings/rng/samsung,exynos5250-trng.txt | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt

diff --git
a/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
new file mode 100644
index 000000000000..5a613a4ec780

--- /dev/null
+++ b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt

@@ -0,0 +1,17 @@
+Exynos True Random Number Generator
+
+Required properties:
+
+- compatible  : Should be "samsung,exynos5250-trng".
+- reg         : Specifies base physical address and size of the registers map.
+- clocks      : Phandle to clock-controller plus clock-specifier pair.
+- clock-names : "secss" as a clock name.
+
+Example:
+
+       rng@10830600 {
+               compatible = "samsung,exynos5250-trng";
+               reg = <0x10830600 0x100>;
+               clocks = <&clock CLK_SSS>;
+               clock-names = "secss";
+       };
--

2.11.0

Mine and Rob's tags disappeared and I think you did not introduce any
major changes here, right?

A very experienced kernel developer adviced me to remove them.

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics