Thread (3 messages) 3 messages, 3 authors, 2017-11-29

Re: [PATCH] crypto: hifn_795x - Fix a memory leak in the error handling path of 'hifn_probe()'

flat view

From: PrasannaKumar Muralidharan <hidden>
Date: 2017-11-20 15:09:52
Also in: kernel-janitors, lkml

Hi Christophe,

On 18 November 2017 at 19:15, Christophe JAILLET
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
'dev' is leaking in the error handling path of 'hifn_probe()'.

Add a 'kfree(dev)' to match the code in 'hifn_remove()'

Signed-off-by: Christophe JAILLET <redacted>
---
 drivers/crypto/hifn_795x.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index e09d4055b19e..a5a36fe7bf2c 100644
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -2579,6 +2579,7 @@ static int hifn_probe(struct pci_dev *pdev, const struct pci_device_id *id)
        for (i = 0; i < 3; ++i)
                if (dev->bar[i])
                        iounmap(dev->bar[i]);
+       kfree(dev);

 err_out_free_regions:
        pci_release_regions(pdev);
--
2.14.1
Nice catch.

Reviewed-by: PrasannaKumar Muralidharan <redacted>

Regards,
PrasannaKumar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help