Re: [PATCH v2 7/8] scsi/pmcraid: Remove an unused structure member
From: Hannes Reinecke <hare@suse.de>
Date: 2017-10-17 06:21:33
Also in:
linux-block, linux-nvme, linux-scsi
On 10/17/2017 12:49 AM, Bart Van Assche wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Bart Van Assche <redacted> Reviewed-by: Johannes Thumshirn <redacted> Cc: linux-scsi@vger.kernel.org Cc: Martin K. Petersen <martin.petersen@oracle.com> Cc: Anil Ravindranath <redacted> --- drivers/scsi/pmcraid.h | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/scsi/pmcraid.h b/drivers/scsi/pmcraid.h index 8bfac72a242b..44da91712115 100644 --- a/drivers/scsi/pmcraid.h +++ b/drivers/scsi/pmcraid.h@@ -542,7 +542,6 @@ struct pmcraid_sglist { u32 order; u32 num_sg; u32 num_dma_sg; - u32 buffer_len; struct scatterlist scatterlist[1]; };
This actually is the same story that we've had with ipr (and, looking at the code, those two drivers look awfully similar ...). pmcraid_sglist looks as if it's a hardware-dependent structure, so just removing one entry from the middle of a structure might not be a good idea. But this is something for the pmcraid folks to clarify. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)