Re: [PATCH] crypto: testmgr: don't allocate IV on stack

On Tue, Oct 31, 2017 at 9:59 AM, Herbert Xu [off-list ref] wrote:

On Tue, Oct 31, 2017 at 07:56:26AM +0000, Gilad Ben-Yossef wrote:

quoted

The IV was allocated on the stack in testmgr skcipher tests.
Since HW based tfm providers need to DMA the IV to the HW,
this leads to problems and is detected by the DMA-API debug
code.

Fix it by allocating the IV using kmalloc instead.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>

The driver that is mapping the IV directly should be fixed instead.
Only input that is given in the form of SG lists can be mapped.
Everything else should be copied if they need to go over DMA.

Got it. Will do.

Thanks,
Gilad

Cheers,
--
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru