Hi Jarkko,

On 24 October 2017 at 23:52, Jarkko Sakkinen
[off-list ref] wrote:

On Tue, Oct 24, 2017 at 10:05:20PM +0530, PrasannaKumar Muralidharan wrote:

quoted

quoted

1. Every user in the kernel is using TPM_ANY_NUM, which means there are
   no other users.

Completely agree that there is no in kernel users yet.

And should never be. It's a bogus parameter that makes no sense.

I understood that after seeing latest patch that uses struct tpm_chip.
Sorry for the noise.

quoted

quoted

2. Moving struct tpm_rng to the TPM client is architecturally
   uacceptable.

As there was no response to the patch there is no way to know whether
it is acceptable or not.

I like the idea of removing the tpm rng driver as discussed in other
emails in this thread.

Thank you.

quoted

quoted

3. Using zero deos not give you any better guarantees on anything than
   just using TPM_ANY_NUM.

Chip id is used, not zero.

Sorry I misread the patch first time. Anyway it's not any kind of ID to
be trusted.

Okay.

quoted

quoted

Why this patch is not CC'd to linux-integrity? It modifies the TPM
driver. And in the worst way.

TPM list is moderated and the moderator has not approved it yet.
get_maintainer script did not say about linux-integrity mailing list.

It could be doing things in worst way but it is not known until some
one says. If no one tells it is the case I don't think it is possible
to fix. Which is what happened.

Understood. We've moved to linux-integrity-u79uwXL29TaiAVqoAR/hOA@public.gmane.org MAINTAINERS
update is in the queue for the next kernel release.

Sorry I never knew this.

quoted

quoted

Implementing the ideas that Jason explained is the senseful way to
get stable access. modules.dep makes sure that the modules are loaded
in the correct order.

If that is sensible then it is the way to go.

There must be a reason to believe what is sensible and what is not.
Looks like this RFC has helped in judging that.

Regards,
PrasannaKumar

Would you be interested to work on patch set that would remove the
existing tpm rng driver and make the TPM driver the customer? It's not
that far away from the work you've been doing already.

/Jarkko

I am late to the party. Jason has sent a patch doing that by the time
I read this email.

Thanks and regards,
PrasannaKumar

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot