[PATCH] crypto/s5p-sss: Use common error handling code in s5p_aes_probe()
STALE3269d
From: SF Markus Elfring <hidden>
Date: 2017-10-22 13:05:28
Also in:
kernel-janitors, linux-samsung-soc, lkml
Subsystem:
crypto api, samsung s5p security subsystem (sss) driver, the rest · Maintainers:
Herbert Xu, "David S. Miller", Krzysztof Kozlowski, Vladimir Zapolskiy, Linus Torvalds
From: Markus Elfring <redacted> Date: Sun, 22 Oct 2017 15:00:27 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <redacted> --- drivers/crypto/s5p-sss.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 7ac657f46d15..ea59e184c199 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c@@ -863,16 +863,13 @@ static int s5p_aes_probe(struct platform_device *pdev) pdata->irq_fc = platform_get_irq(pdev, 0); if (pdata->irq_fc < 0) { err = pdata->irq_fc; - dev_warn(dev, "feed control interrupt is not available.\n"); - goto err_irq; + goto report_failure; } err = devm_request_threaded_irq(dev, pdata->irq_fc, NULL, s5p_aes_interrupt, IRQF_ONESHOT, pdev->name, pdev); - if (err < 0) { - dev_warn(dev, "feed control interrupt is not available.\n"); - goto err_irq; - } + if (err < 0) + goto report_failure; pdata->busy = false; pdata->dev = dev;
@@ -906,6 +903,10 @@ static int s5p_aes_probe(struct platform_device *pdev) s5p_dev = NULL; return err; + +report_failure: + dev_warn(dev, "feed control interrupt is not available.\n"); + goto err_irq; } static int s5p_aes_remove(struct platform_device *pdev)
--
2.14.2