Re: [PATCH] crypto: ccp - Fix XTS-AES support on a version 5 CCP

On 07/18/2017 01:28 AM, Stephan Müller wrote:

Am Montag, 17. Juli 2017, 22:08:27 CEST schrieb Gary R Hook:

Hi Gary,

quoted

Version 5 CCPs have differing requirements for XTS-AES: key components
are stored in a 512-bit vector. The context must be little-endian
justified. AES-256 is supported now, so propagate the cipher size to
the command descriptor.

Signed-off-by: Gary R Hook <redacted>
---
 drivers/crypto/ccp/ccp-crypto-aes-xts.c |   79

...<snip>...

quoted

@@ -97,14 +77,20 @@ static int ccp_aes_xts_setkey(struct crypto_ablkcipher

*tfm, const u8 *key, unsigned int key_len)
 {
       struct ccp_ctx *ctx = crypto_tfm_ctx(crypto_ablkcipher_tfm(tfm));
+     unsigned int ccpversion = ccp_version();

       /* Only support 128-bit AES key with a 128-bit Tweak key,
        * otherwise use the fallback
        */
+

Can you please add xts_check_key here?

Certainly!