Re: [PATCH v10 1/2] crypto: skcipher AF_ALG - overhaul memory management
flat view
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2017-06-23 06:11:10
On Wed, Jun 21, 2017 at 10:03:02PM +0200, Stephan Müller wrote:
+ /* convert iovecs of output buffers into RX SGL */
+ while (len < ctx->used && msg_data_left(msg)) {How are we supposed to reach the wait path when ctx->used == 0?
quoted hunk ↗ jump to hunk
+ /* + * This error covers -EIOCBQUEUED which implies that we can + * only handle one AIO request. If the caller wants to have + * multiple AIO requests in parallel, he must make multiple + * separate AIO calls. + */ + if (err < 0) { + if (err == -EIOCBQUEUED) + ret = err; + goto out; } + if (!err) + goto out;
You can combine the two now as err <= 0. Thanks, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt