Thread (2 messages) 2 messages, 2 authors, 2017-02-27
STALE3502d

[PATCH] crypto: cavium: fix leak on curr if curr->head fails to be allocated

From: Colin King <hidden>
Date: 2017-02-17 15:57:53
Also in: kernel-janitors, lkml
Subsystem: cavium octeon-tx crypto driver, crypto api, the rest · Maintainers: George Cherian, Herbert Xu, "David S. Miller", Linus Torvalds

From: Colin Ian King <redacted>

The exit path when curr->head cannot be allocated fails to kfree the
earlier allocated curr.  Fix this by kfree'ing it.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/crypto/cavium/cpt/cptvf_main.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/cavium/cpt/cptvf_main.c b/drivers/crypto/cavium/cpt/cptvf_main.c
index 527bdc3..3247c7f 100644
--- a/drivers/crypto/cavium/cpt/cptvf_main.c
+++ b/drivers/crypto/cavium/cpt/cptvf_main.c
@@ -242,6 +242,7 @@ static int alloc_command_queues(struct cpt_vf *cptvf,
 			if (!curr->head) {
 				dev_err(&pdev->dev, "Command Q (%d) chunk (%d) allocation failed\n",
 					i, queue->nchunks);
+				kfree(curr);
 				goto cmd_qfail;
 			}
 
-- 
2.10.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help