[PATCH] drivers: crypto: cpt: cpt_bind_vq_to_grp could return an error code
From: George Cherian <hidden>
Date: 2017-02-14 09:24:03
Also in:
lkml
Subsystem:
cavium octeon-tx crypto driver, crypto api, the rest · Maintainers:
George Cherian, Herbert Xu, "David S. Miller", Linus Torvalds
cpt_bind_vq_to_grp() could return an error code. However, it currently returns a u8. This produce the static checker warning. drivers/crypto/cavium/cpt/cptpf_mbox.c:70 cpt_bind_vq_to_grp() warn: signedness bug returning '(-22)' Reported-by: Dan Carpenter <redacted> Signed-off-by: George Cherian <redacted> --- drivers/crypto/cavium/cpt/cptpf_mbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/cavium/cpt/cptpf_mbox.c b/drivers/crypto/cavium/cpt/cptpf_mbox.c
index 5818b41..20f2c6e 100644
--- a/drivers/crypto/cavium/cpt/cptpf_mbox.c
+++ b/drivers/crypto/cavium/cpt/cptpf_mbox.c@@ -59,7 +59,7 @@ static void cpt_cfg_vq_priority(struct cpt_device *cpt, int vf, u32 pri) cpt_write_csr64(cpt->reg_base, CPTX_PF_QX_CTL(0, vf), pf_qx_ctl.u); } -static u8 cpt_bind_vq_to_grp(struct cpt_device *cpt, u8 q, u8 grp) +static int cpt_bind_vq_to_grp(struct cpt_device *cpt, u8 q, u8 grp) { struct microcode *mcode = cpt->mcode; union cptx_pf_qx_ctl pf_qx_ctl;
@@ -90,7 +90,7 @@ static void cpt_handle_mbox_intr(struct cpt_device *cpt, int vf) { struct cpt_vf_info *vfx = &cpt->vfinfo[vf]; struct cpt_mbox mbx = {}; - u8 vftype; + int vftype; struct device *dev = &cpt->pdev->dev; /* * MBOX[0] contains msg
--
2.1.4