Re: [PATCH v3 2/3] crypto: brcm: Add Broadcom SPU driver
From: Rob Rice <hidden>
Date: 2017-02-02 15:12:05
Also in:
linux-arm-kernel, linux-devicetree, lkml
From: Rob Rice <hidden>
Date: 2017-02-02 15:12:05
Also in:
linux-arm-kernel, linux-devicetree, lkml
Herbert,
On Feb 2, 2017, at 9:05 AM, Herbert Xu [off-list ref] wrote: On Wed, Jan 25, 2017 at 11:44:48AM -0500, Rob Rice wrote:quoted
+static int ahash_export(struct ahash_request *req, void *out) +{ + const struct iproc_reqctx_s *rctx = ahash_request_ctx(req); + + memcpy(out, rctx, offsetof(struct iproc_reqctx_s, msg_buf)); + return 0; +}The reqctx data structure seems to contain a lot of info unrelated to the hash state. Can't we get away with just copying the hash state (incr_hash) itself?
Yes, I see your point. I’ll whittle the export state down to just what’s needed for the hash.
Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html