Thread (16 messages) 16 messages, 5 authors, 2017-01-10

Re: [PATCH v2 1/4] lib: Update LZ4 compressor module based on LZ4 v1.7.2.

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2017-01-08 11:22:08
Also in: lkml

On Sat, Jan 07, 2017 at 05:55:42PM +0100, Sven Schmidt wrote:
+/*!LZ4_compressbound() :
+    Provides the maximum size that LZ4 may output in a "worst case" scenario
+    (input data not compressible)
+*/
Odd coding style, please use kerneldoc format if you are going to have
comments like this.
+static inline int LZ4_compressBound(int isize) {
+  return LZ4_COMPRESSBOUND(isize);
And follow the proper kernel coding style rules, putting your patches
through scripts/checkpatch.pl should help you out here.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help