Thread (70 messages) flat view 70 messages, 11 authors, 2016-12-18

Re: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: 2016-12-14 17:50:06
Also in: lkml, netdev

On Wed, Dec 14, 2016 at 3:47 PM, David Laight [off-list ref] wrote:
Just remove the __packed and ensure that the structure is 'nice'.
This includes ensuring there is no 'tail padding'.
In some cases you'll need to put the port number into a 32bit field.
I'd rather not. There's no point in wasting extra cycles on hashing
useless data, just for some particular syntactic improvement. __packed
__aligned(8) will do what we want perfectly, I think.
I'd also require that the key be aligned.
Yep, I'll certainly do this for the siphash24_aligned version in the v3.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help