Thread (17 messages) 17 messages, 4 authors, 2016-11-13
STALE3499d REVIEWED: 1 (0M)

[PATCH v2 04/11] nios2: fix timer initcall return value

From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-11-10 16:47:42
Also in: linux-kbuild, linux-media, linux-nfs, linux-s390, lkml
Subsystem: nios2 architecture, the rest · Maintainers: Dinh Nguyen, Simon Schuster, Linus Torvalds

When called more than twice, the nios2_time_init() function
return an uninitialized value, as detected by gcc -Wmaybe-uninitialized

arch/nios2/kernel/time.c: warning: 'ret' may be used uninitialized in this function

This makes it return '0' here, matching the comment above the
function.

Acked-by: Ley Foon Tan <redacted>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/nios2/kernel/time.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/nios2/kernel/time.c b/arch/nios2/kernel/time.c
index d9563dd..746bf5c 100644
--- a/arch/nios2/kernel/time.c
+++ b/arch/nios2/kernel/time.c
@@ -324,6 +324,7 @@ static int __init nios2_time_init(struct device_node *timer)
 		ret = nios2_clocksource_init(timer);
 		break;
 	default:
+		ret = 0;
 		break;
 	}
 
-- 
2.9.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help